[impldef] Fixed index entry collation to support keys containing code #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One consequence of the auto-generation of the collation order is that nested magic underscores (provided by the |
tkoeppe
force-pushed
the
coll
branch
2 times, most recently
from
46f0875
to
115b45f
Compare
tkoeppe
force-pushed
the
coll
branch
2 times, most recently
from
f9a78e9
to
1a684df
Compare
|
This change will impose the following permanent maintenance cost:
I think that's manageable, but it's something that might catch you out as you add new content and it suddenly doesn't compile. |
|
The two pages of diffs are now:
|
tkoeppe
force-pushed
the
coll
branch
5 times, most recently
from
8964f3b
to
545fb4a
Compare
|
Superseded by PR #834. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, I reworked this. The new solution involves stripping out certain well-known commands from the index text and using the bare text for collation, while retaining the original text for the index entry. The stripped commands are
\tcode,\_,\mnameand\grammarterm.For advanced entries that add further index structure, this duplication mechanism fails, so we provide a new macro
\impldefplainthat has the original functionality. It's only used for one set of entries (value of bit-fields).Only two pages of diffs.