New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[utility,iterator] Apply p0174r2 deprecating vestigial library compon… #773
Conversation
@zygoloid, @burblebee: Just a heads up that Alisdair has provided a PR to apply one of the motions. |
T* address(T& x) const noexcept; | ||
const T* address(const T& x) const noexcept; | ||
|
||
T* allocate(size_t, const void* hint); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the first parameter get a name here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - this error was present in the original standard too. FIXED
…ents Moves text (with minor tweaks, per p0174r2) to Annex D for deprecation, and updates the indices accordingly. A drive-by fix in allocator so that operator==/!= in the synopsis use the same parameter names in the definition.
382570b
to
c77c723
Compare
Force-pushed an amended branch to address Tim's comments, and apply with a clean history. |
@zygoloid, @burblebee, @jwakely: Until now, motion applications had commits titled |
My preference would be without the [stable.name] for non-editorial changes. The point of putting that in the commit message is to know where changes happened, but with a paper number the paper provides that info. Not my call though. |
I absorbed this into a branch on cplusplus/draft as commit b086b8a. |
Motions get commit messages like:
LWG/CWG issues get commit messages like:
Editorial issues get commit messages like:
Editorial changes get commit messages like:
|
@burblebee Nice summary - that should go on the wiki! |
…ents
Moves text (with minor tweaks, per p0174r2) to Annex D
for deprecation, and updates the indices accordingly.
A drive-by fix in allocator so that operator==/!= in
the synopsis use the same parameter names in the
definition.
Fix use of 'reference' with 'T&' in std::allocator as an
editorial fix missed by the original paper.