Travis CI: Fail build if regenerated xref and grammar files don't match those in repository #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
One alternative that you may prefer would be to have these tests as a separate build type (their own row in the matrix). This would allow the other builds to complete and only fail if building |
|
An example of what having the tests as a separate matrix item looks like is at https://travis-ci.org/godbyk/draft/builds/141772422. |
|
This is obsolete after PR #816. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch causes the Travis CI builds to fail if they detect that the newly generated grammar and xref files differ from those committed to the git repository.
Figure PDFs are currently ignored as regenerated PDFs will always differ from the committed PDFs due to changed metadata (build date/time, primarily). If a better solution for diffing the PDFs is found, we can add this test in the future.
This PR follows the discussion near the end of #635.