[stmt.if] Balance brackets and fix indentation. #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -276,7 +276,7 @@ | |||
| template<typename T, typename ... Rest> void g(T&& p, Rest&& ...rs) { | |||
| // ... handle \tcode{p} | |||
|
|
|||
| if constexpr (sizeof...(rs) > 0) | |||
| if constexpr (sizeof...(rs) > 0) { | |||
There was a problem hiding this comment.
No, this isn't right; the closing brace matches the opening brace on line 276. It's the indent of what follows that's wrong, and the brace on line 293 is extraneous. See P0292R2.
|
Ah ok, re-pushed |
|
Thanks. Can you please update the commit message? |
|
Done :) |
|
Can you please rebase, and also change the PR title to match the commit? |
Eelis
changed the title
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.