[diff.basic] Fix format and inexact wording #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
force-pushed
the
master
branch
2 times, most recently
from
6f5c913
to
bbb0244
Compare
|
@FrankHB: Can you please rebase (and sorry for the force-pushes on master)? |
FrankHB
force-pushed
the
patch-11
branch
2 times, most recently
from
e140b61
to
167df7c
Compare
Though Annex C is informative, it's better to keep the terminology similar to normative text, which is easier to refer.
| values for each \tcode{const}. | ||
| This feature allows the user to put \tcode{const}objects in header files that are included | ||
| in many compilation units. | ||
| for each \tcode{const} object. |
There was a problem hiding this comment.
The grammar doesn't work here: "provide explicit initializer for each const object." Maybe "provide an explicit initializer[...]"?
| \Cpp, this feature urges programmers to provide an explicit initializer | ||
| for each \tcode{const} object. | ||
| This feature allows the user to put \tcode{const} objects in headers or source files that are included | ||
| in more than one translation units. |
There was a problem hiding this comment.
Shouldn't it say "more than one unit", singular?
Signed-off-by: FrankHB <frankhb1989@gmail.com>
| Because \tcode{const} objects may be used as values during translation in | ||
| \Cpp, this feature urges programmers to provide an explicit initializer | ||
| for each \tcode{const} object. | ||
| This feature allows the user to put \tcode{const} objects in headers or source files that are included |
There was a problem hiding this comment.
Say just "objects in source files"; @zygoloid says that "users have no control over headers". Then I'll merge this.
Signed-off-by: FrankHB <frankhb1989@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though Annex C is informative, it's better to keep the terminology similar to normative text, which is easier to refer.