[clause 27] Index all member functions in clause 27 #820
Conversation
Some work remains to properly index all of the free (namespace scope) funtions.
| \indexlibrary{\idxcode{ios_base}!\idxcode{fmtflags}}% | ||
| \indexlibrary{\idxcode{fmtflags}!\idxcode{ios_base}}% |
There was a problem hiding this comment.
Is this entry correct? It looks like the function is called flags, nofmtflags?!
There was a problem hiding this comment.
Fixed - thanks, thought I had caught all of these (there were not many).
| @@ -13249,6 +13479,7 @@ | |||
| These functions enable use of \tcode{recursive_directory_iterator} | |||
| with range-based for statements. | |||
|
|
|||
| \indexlibrary{\idxcode{begin}!\idxcode{recursive_directory_iterator}}% | |||
There was a problem hiding this comment.
Why is there only one version of this index entry? Is this not a member function?
There was a problem hiding this comment.
I believe this is for the free-function overloads.
| @@ -6029,7 +6114,7 @@ | |||
| defines a class that is responsible for doing exception safe prefix and suffix | |||
| operations. | |||
|
|
|||
| \indexlibrary{\idxcode{sentry}!constructor}% | |||
There was a problem hiding this comment.
Why are you deleting this here, but you left both "sentry" and "basic_ostream::sentry" for the destructor?
There was a problem hiding this comment.
As far as I can tell, I am consistent for constructor and destructor - the difference is between basic_istream::sentry and basic_ostream::sentry. In one case, I retain the old index entry and add the new one, in the other, I just rename the old to the new.
I agree they should be consistent, but not sure which way we think is the best to resolve. I mildly lean towards retaining both 'sentry!constructor' and 'basic_Xstream::sentry!constructor' (and similarly for destructors), but I lean the other way for 'operator bool' - with is terribly inconsistent of me again.
Preferences?
There was a problem hiding this comment.
None at all. We can leave it as is :-)
Index member functions in Clause 27
Some work remains to properly index all of the free (namespace scope) functions.
Will review other clauses later, especially those clauses with lots of additions for C++17.