Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diagnostics] audit index entries for clause 19 #829

Merged
merged 1 commit into from Jul 18, 2016

Conversation

AlisdairM
Copy link
Contributor

The only issues that turned up are missing '%' continuations
at the end of around half of the index entry lines. This
patch consistently cleans that up, so that every index entry
terminates in a '%', but it is not clear that this has any
effect on the final rendering, and the patch could safely be
rejected. The primary benefit is consistency, should we ever
want to write some follow-up tooling to analyze index entries.

Audit confirmed that every \begin{itemdecl} is indexed, and the
index entry matches the declared name(s).

The only issues that turned up are missing '%' continuations
at the end of around half of the index entry lines.  This
patch consistently cleans that up, so that every index entry
terminates in a '%', but it is not clear that this has any
effect on the final rendering, and the patch could safely be
rejected.  The primary benefit is consistency, should we ever
want to write some follow-up tooling to analyze index entries.
@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 15, 2016

You could run diffpdf to see if there's any effect.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 18, 2016

OK, no diffs. I have no particular opinion on this change, but I suppose it can't hurt, and it's "leading by example" regarding consistency.

@tkoeppe tkoeppe merged commit 9d9e417 into cplusplus:master Jul 18, 2016
@AlisdairM AlisdairM deleted the audit_index_19 branch August 8, 2016 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants