Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reverse.iter.ops] Sync and simplify several reverse_iterator member function prototype declarations #831

Closed
Dani-Hub opened this issue Jul 16, 2016 · 0 comments
Closed

[reverse.iter.ops] Sync and simplify several reverse_iterator member function prototype declarations #831

Dani-Hub opened this issue Jul 16, 2016 · 0 comments
Assignees
@jensmaurer

Comments

@Dani-Hub
Copy link
Member

Dani-Hub commented Jul 16, 2016 •
edited

Between [reverse.iter.op+] and [reverse.iter.opindex], the prototype declarations should be brought in sync with the class template synopsis in [reverse.iterator] by removing the added "typename reverse_iterator<Iterator>::" prefixes to make them more readable:

a) [reverse.iter.op+]:

constexpr reverse_iterator
operator+(typename reverse_iterator<Iterator>::difference_type n) const;

=>

constexpr reverse_iterator operator+(difference_type n) const;

b) [reverse.iter.op+=]:

constexpr reverse_iterator&
operator+=(typename reverse_iterator<Iterator>::difference_type n);

=>

constexpr reverse_iterator& operator+=(difference_type n);

c) [reverse.iter.op-]:

constexpr reverse_iterator
operator-(typename reverse_iterator<Iterator>::difference_type n) const;

=>

constexpr reverse_iterator operator-(difference_type n) const;

d) [reverse.iter.op-=]:

constexpr reverse_iterator&
operator-=(typename reverse_iterator<Iterator>::difference_type n);

=>

constexpr reverse_iterator& operator-=(difference_type n);

e) [reverse.iter.opindex]:

constexpr _unspecified_ operator[](
typename reverse_iterator<Iterator>::difference_type n) const;

=>

constexpr _unspecified_ operator[](difference_type n) const;
jensmaurer added a commit to jensmaurer/draft that referenced this issue Nov 22, 2016
@jensmaurer
[reverse.iter.ops] Simplify reverse_iterator operator function declar…
afbea84 
…ations by using non-dependent difference_type.

Fixes cplusplus#831.
@jensmaurer jensmaurer mentioned this issue Nov 22, 2016
Merged
@jensmaurer jensmaurer changed the title Sync and simplify several reverse_iterator member function prototype declarations [reverse.iter.ops] Sync and simplify several reverse_iterator member function prototype declarations Nov 22, 2016
tkoeppe pushed a commit that referenced this issue Nov 22, 2016
@jensmaurer @tkoeppe
[reverse.iter.ops] Simplify reverse_iterator operator function declar…
f8013a4 
…ations by using non-dependent difference_type. (#1098)

Fixes #831.
@jensmaurer jensmaurer self-assigned this Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dani-Hub @jensmaurer