Add constexpr to optional::value_or(U&&) && #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This constexpr specifier is present in the `<optional>` synopsis, but omitted from the detailed specification in [optional.object.observe]. (I understand I'm stretching the definition of "editorial" here. Please let me know if the editors feel this change is substantive, and I'll file a defect report with LWG.)
|
This is OK to fix editorially; the detailed specification is only supposed to specify which function from the synopsis we're referring to, and it's not uncommon for elements that don't affect the signature to be omitted (exception specifiers, |
cpplearner
added a commit
to cpplearner/fundamentals-ts
that referenced
this pull request
Jul 23, 2016
This change is present in [N4078](http://www.open-std.org/JTC1/SC22/WG21/docs/papers/2014/n4078.html), but for some reason was missed when [N4078 was applied](cplusplus@7b47f9c). See also cplusplus/draft#839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constexpr specifier is present in the
<optional>synopsis, but omitted from the detailed specification in [optional.object.observe]. (I understand I'm stretching the definition of "editorial" here. Please let me know if the editors feel this change is substantive, and I'll file a defect report with LWG.)