Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[re.traits] Remove excessive newlines from codeblocks. #867

Merged
merged 1 commit into from Jul 28, 2016
Merged

[re.traits] Remove excessive newlines from codeblocks. #867

merged 1 commit into from Jul 28, 2016

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Jul 28, 2016 •
edited

These two newlines are visible in the pdf as awkward whitespace.

I also tried a larger patch which removed trailing newlines and spliced adjacent codeblocks as well, but that seemed to have no visible effect.

@jwakely
Copy link
Member

jwakely commented Jul 28, 2016

It looks like there's another one on line 1229 that doesn't need to be there

@Eelis Eelis changed the title [re.traits] Remove leading newlines from codeblocks. [re.traits] Remove excessive newlines from codeblocks. Jul 28, 2016
@Eelis
Copy link
Contributor Author

Eelis commented Jul 28, 2016

Ok, added that one as well

@jwakely jwakely merged commit 2738a07 into cplusplus:master Jul 28, 2016
@jwakely
Copy link
Member

jwakely commented Jul 28, 2016

thanks

@Eelis Eelis deleted the codeblocks branch July 28, 2016 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Eelis @jwakely