Remove redundant this-> in library specification
#884
Conversation
| @@ -3617,7 +3617,7 @@ | |||
| \effects | |||
| Equivalent to: | |||
| \begin{codeblock} | |||
| return basic_string_view<charT, traits>(this.data(), pos1, n1).compare(sv); | |||
There was a problem hiding this comment.
Do we ever say this-> elsewhere? Wouldn't we just say data()?
There was a problem hiding this comment.
The other any::emplace, for one. A quick search shows a few dozen this->s in the library clauses.
There was a problem hiding this comment.
Almost all of them appear to be very recent additions and redundant. I would prefer to remove all of these occurrences that are neither necessary ([filebuf.assign]/1's this-> is necessary since close is a member of a dependent base class) nor significantly improve clarity.
There was a problem hiding this comment.
OK, I'll prepare a commit removing them all instead.
What dependent base, though? close is a member of basic_filebuf, not basic_streambuf.
…t 'this->'. Also a drive-by \tcode fix in [variant.assign].
|
I left four |
timsong-cpp
changed the title
this.meow()sthis-> in library specification
in [string::compare] and [any.modifiers].
Also fix a missing
\tcodein [variant.assign] discovered on the way.