Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small typo in [any.modifiers]/2 #913

Closed
StephanTLavavej opened this issue Sep 2, 2016 · 4 comments
Closed

Small typo in [any.modifiers]/2 #913

StephanTLavavej opened this issue Sep 2, 2016 · 4 comments

Comments

@StephanTLavavej
Copy link
Contributor

N4606 20.8.3.3 [any.modifiers]/2 says "Effects: Calls this.reset()." It should say this->reset() or eliminate this entirely (e.g. /10 just refers to has_value() by itself).
@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 2, 2016

Thanks - could you send a PR please?

@StephanTLavavej
Copy link
Contributor Author

I'm on Windows and I've never built the Standard from its sources here (I tried once in a Linux VM). Which is why I submit issues instead of PRs when I find typos. I know I should figure out the build process someday.

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 2, 2016

I believe you can make edits directly in the GitHub web interface nowadays. No need to actually build anything, we have Travis for that :-) For small changes like this, I'm perfectly happy to just review the source changes.

@timsong-cpp
Copy link
Contributor

Already fixed by #884.

@tkoeppe tkoeppe closed this as completed Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StephanTLavavej @tkoeppe @timsong-cpp