[meta] Add index entries for each type trait #922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create an index entry for each row in the type traits tables, indexing the corresping trait. Where a trait is defined outside the table, add a second index reference to the latter. This causes an annoying duplication, as the current software sees the index entry inside the table as in some way NOT the same as the entry outside the table. Disambiguate the is_empty function from the filesystem library, and the is_empty trait. The issue for is_signed being a trait and a member of numberic_limits resolves itself.
|
I see there's currently no index entry for void_t. Maybe worth adding? |
|
I think I would rather handle this under a follow-up patch. Adding an entry for 'void_t' makes sense, but currently there are no entries for any other '_t' alias in this patch. I am not currently aware of precedent for sprinkling indexing markup into header synopses. 'void_t' is definitely a noteworthy special case though. |
|
Ok makes sense, thanks |
zygoloid
requested changes
Sep 22, 2016
| @@ -15739,6 +15847,7 @@ | |||
| needed when only explicit conversions are desired among the template arguments. | |||
| \end{note} \\ \rowsep | |||
|
|
|||
| \indexlibrary{\idxcode{underlying_type}}% | |||
There was a problem hiding this comment.
Seems to be missing the end of the line.
There was a problem hiding this comment.
Looks like this might be a github bug? Some other views of this file show the file ending here!
|
Looks like we hit a github bug here; manually checked and merged as d5a02ce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an index entry for each row in the type traits tables,
indexing the corresping trait. Where a trait is defined outside
the table, add a second index reference to the latter. This
causes an annoying duplication, as the current software sees the
index entry inside the table as in some way NOT the same as the
entry outside the table.
Disambiguate the is_empty function from the filesystem library,
and the is_empty trait. The issue for is_signed being a trait
and a member of numberic_limits resolves itself.
This is intended to resolve #905