[optional.nullopt] Add missing 'the'. #951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
reviewed
Oct 13, 2016
| @@ -2969,7 +2969,7 @@ | |||
| this indicates that an optional object not containing a value shall be constructed. | |||
|
|
|||
| \pnum | |||
| Type \tcode{nullopt_t} shall not have a default constructor. It shall be a literal type. Constant \tcode{nullopt} shall be initialized with an argument of literal type. | |||
| Type \tcode{nullopt_t} shall not have a default constructor. It shall be a literal type. The constant \tcode{nullopt} shall be initialized with an argument of literal type. | |||
There was a problem hiding this comment.
No definite article here?
Can you locate the paper that provided the wording, just for double-checking?
There was a problem hiding this comment.
The "the" is missing here as well: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3793.html
There was a problem hiding this comment.
I guess it's technically grammatically correct without the "the", too... Just sounds weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Pure coincidence that I spotted two of these today. Unfortunately I have no way to search for these systematically.)