[associative.reqmts, unord.req] insert_return_type only for unique keys #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requirements for associative and unordered associative containers require `insert_return_type` for all containers, but it's only defined for containers with unique keys.
danieljames
force-pushed
the
insert-return-type-only-unique
branch
from
d680856
to
b8eb3a4
Compare
danieljames
changed the title
|
I agree this is an issue, but I don't think it's an editorial one. It's possible that the return type will be changed to |
|
OK, thanks. I'll submit one soon. |
|
Great, thanks. You could mention in the issue that it depends on the resolution to LWG 2772. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requirements for associative and unordered associative containers require
insert_return_typefor all containers, but it's only defined for containers with unique keys.I'm not sure about the wording, I followed the example of other entries in the table which say things like (map and multimap only), although it might be better to say it's only for containers that support unique keys.
I think this is an editorial change, because it just changes the requirements to match what's specified elsewhere.