[whole draft] Use \tcode{true} and \tcode{false} consistently #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaire
changed the title
\tcode{true} and \tcode{false} consistently
jlaire
force-pushed
the
tcode-true-false
branch
from
4212f58
to
b920635
Compare
jlaire
changed the title
zygoloid
reviewed
Nov 12, 2016
| @@ -2945,7 +2945,7 @@ | |||
| function determines the integral conversion specifier as indicated in | |||
| Table~\ref{tab:localization.integer.conversions.in}. | |||
| The table is ordered. | |||
| That is, the first line whose condition is true applies. | |||
| That is, the first line whose condition is \tcode{true} applies. | |||
There was a problem hiding this comment.
This isn't really talking about a value of type bool (at least for the fourth and fifth lines of the table). How about "whose condition is met" instead?
There was a problem hiding this comment.
True. I'll just leave this unchanged.
zygoloid
reviewed
Nov 12, 2016
| @@ -3113,7 +3113,7 @@ | |||
| \\ \rowsep | |||
| \tcode{m.suffix().matched} | |||
| & | |||
| false | |||
| \tcode{false} | |||
| \\ \rowsep | |||
| \tcode{m[0].first} | |||
| & | |||
There was a problem hiding this comment.
Can you apply \tcode to all the firsts and lasts in this table too?
|
Looks good other than the couple of issues noted above. |
jlaire
force-pushed
the
tcode-true-false
branch
2 times, most recently
from
2fe5ace
to
1527936
Compare
jlaire
force-pushed
the
tcode-true-false
branch
from
1527936
to
ed2e3b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.