Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0627 Function to mark unreachable code #275

Closed
jensmaurer opened this issue Jan 28, 2019 · 17 comments · Fixed by cplusplus/draft#5279
Closed

P0627 Function to mark unreachable code #275

jensmaurer opened this issue Jan 28, 2019 · 17 comments · Fixed by cplusplus/draft#5279
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 C++23 Targeted at C++23 expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - small paper size estimate
Milestone

Comments

@jensmaurer
Copy link
Member

jensmaurer commented Jan 28, 2019

P0627R3 Function to mark unreachable code (Melissa Mears)

https://issues.isocpp.org/show_bug.cgi?id=501

@jensmaurer jensmaurer added this to the 2019-02 milestone Jan 28, 2019
@jensmaurer jensmaurer added LEWG Library Evolution LWG Library and removed LEWG Library Evolution labels Jan 28, 2019
@jensmaurer jensmaurer added this to Wednesday in LWG in Kona 2019 Feb 5, 2019
@mclow mclow added the needs-revision Paper needs changes before it can proceed label Feb 22, 2019
@mclow
Copy link

mclow commented Feb 22, 2019

Reviewed in LWG on Thursday; paper needs minor edits.

@jensmaurer jensmaurer removed this from Wednesday in LWG in Kona 2019 Feb 25, 2019
@jensmaurer jensmaurer removed this from the 2019-02 milestone Mar 21, 2019
@mclow mclow added C++20 Targeted at C++20 and removed needs-revision Paper needs changes before it can proceed labels Jul 15, 2019
@mclow
Copy link

mclow commented Jul 15, 2019

New version D0627r4

@mclow mclow removed the C++20 Targeted at C++20 label Nov 3, 2019
@mclow
Copy link

mclow commented Nov 3, 2019

This was not adopted for C++20. Removing the "C++20" label.

@JeffGarland
Copy link
Member

LWG small group in Prague -- author was sent feedback.

@JeffGarland JeffGarland added C++23 Targeted at C++23 needs-revision Paper needs changes before it can proceed labels Feb 17, 2020
@jensmaurer jensmaurer added IS Ship vehicle: IS and removed C++23 Targeted at C++23 labels Feb 18, 2020
@JeffGarland JeffGarland added the lwg-prereview Needs LWG initial review before full group label Mar 24, 2020
@ben-craig ben-craig added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e size - small paper size estimate labels Oct 17, 2020
@cor3ntin
Copy link

cor3ntin commented Sep 2, 2021

@JeffGarland @brycelelbach @villevoutilainen

Are we able to reach the author? Otherwise, how can we help this paper make progress?

@AaronBallman AaronBallman added the SG22 C / C++ liaison label Sep 2, 2021
@JeffGarland
Copy link
Member

@cor3ntin - The last attempt was after the Prague meeting -- there was no response. I don't know the author so perfectly possible my email went to spam. As a general rule, however, I'm don't have time to babysit authors w.r.t. updating papers. That said if someone knows the author and would like to try again we'd be happy to help with getting the changes done and scheduling the review.

The feedback supplied was from this wiki page:

https://wiki.edg.com/bin/view/Wg21prague/LWGSatAfternoonSmallGroupReviews

@jensmaurer
Copy link
Member Author

jensmaurer commented Sep 5, 2021

@cor3ntin, I should be taking over. I got the source document back in June, but it slipped. Trying again for the next mailing.

@JeffGarland
Copy link
Member

@jensmaurer Happy to look at this before the mailing -- that is, ready to schedule as soon as you update. Let me know if there are questions from the wiki notes, but I think they are mostly minor things which you're well familiar with.

@brycelelbach brycelelbach added LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll labels Sep 14, 2021
@JeffGarland
Copy link
Member

JeffGarland commented Sep 17, 2021

LWG reviewed on 2021-09-10 and removed an overload as not supportable by implementations, but approved the paper otherwise for C++23 pending the ok from LEWG.

JM: the paper is in front of the LEWG for the removal of the message overload

@ben-craig it was noted that this facility should likely be part of freestanding.

https://wiki.edg.com/bin/view/Wg21telecons2021/P0627-20210910

Accept P0627r5 to C++23 pending LEWG approval of the updated design?

F A N
11 0 0

@jensmaurer
Copy link
Member Author

LEWG reflector discussion started 2021-09-09: http://lists.isocpp.org/lib-ext/2021/09/19890.php

@brycelelbach brycelelbach added the expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. label Sep 18, 2021
@brycelelbach
Copy link

brycelelbach commented Sep 18, 2021

A Library Evolution motion was made on the mailing list to electronic poll removing the message parameter. There was a substantial amount of discussion, but that discussion was largely clarifications about std::unreachable or inquires about how it is implemented, not objections to the removal of the message parameter. As such, Library Evolution will proceed with electronic polling the removal of the message parameter. We'll also need to affirm that std::unreachable belongs in freestanding.

@JeffGarland JeffGarland added C++23 Targeted at C++23 and removed lwg-prereview Needs LWG initial review before full group labels Sep 18, 2021
@wg21bot
Copy link
Collaborator

wg21bot commented Sep 20, 2021

P0627R5 Function to mark unreachable code (Jens Maurer)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label Sep 20, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone Sep 20, 2021
@AaronBallman
Copy link
Collaborator

This paper was discussed at the Oct 1 2021 SG22 meeting. No polls were taken and SG22 does not need to see this paper again.

@AaronBallman AaronBallman removed the SG22 C / C++ liaison label Oct 4, 2021
@wg21bot
Copy link
Collaborator

wg21bot commented Oct 26, 2021

P0627R6 Function to mark unreachable code (Jens Maurer)

@JeffGarland
Copy link
Member

Per our prior review and vote I'm setting this ready for plenary since LEWG agrees with the suggested changes from our prior review. The R6 change was editorial and doesn't require LWG to re-review.

@JeffGarland JeffGarland added the tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. label Oct 28, 2021
@brycelelbach brycelelbach added B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 and removed B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e labels Oct 31, 2021
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Nov 9, 2021
@cor3ntin cor3ntin removed ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review LEWG Library Evolution expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. labels Dec 6, 2021
@cor3ntin
Copy link

cor3ntin commented Dec 6, 2021

2021-11 Library Evolution Electronic Poll Outcomes

Send [P0627R6] (Function To Mark Unreachable Code), which was previously approved and has been modified to remove the message parameter, to Library Working Group for C++23, classified as an addition ([P0592R4] bucket 3 item)

SF F N A SA
27 4 1 0 0

Strong consensus in favor

@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@cor3ntin cor3ntin added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Feb 7, 2022
@jensmaurer
Copy link
Member Author

Approved by WG21 plenary 2022-02-07

@cor3ntin cor3ntin removed the tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. label Feb 21, 2022
@brycelelbach brycelelbach added the expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 C++23 Targeted at C++23 expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - small paper size estimate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants