Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1679 String Contains function #457

Closed
wg21bot opened this issue Jun 23, 2019 · 8 comments · Fixed by cplusplus/draft#4373
Closed

P1679 String Contains function #457

wg21bot opened this issue Jun 23, 2019 · 8 comments · Fixed by cplusplus/draft#4373
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - small paper size estimate
Milestone
2020-telecon

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Jun 23, 2019

P1679R0 String Contains function (Wim Leflere)
@wg21bot wg21bot added this to the 2019-07 milestone Jun 23, 2019
@wg21bot wg21bot added the LEWGI Library Evolution Incubator label Jun 23, 2019
@brycelelbach
Copy link

brycelelbach commented Jul 17, 2019 •
edited

Cologne 2019-07 LEWGI Minutes

P1679R0 std::string::contains: Direction Review

Champion: Wim Leflere

Minute Taker: Phil Ratzloff

Start Overview: 07-17 15:53

Start Review: 15:59

This is the same paper as P1657R0, which is scheduled for Friday in LEWG.

Start Polling: 16:06

POLL: We should promise more committee time to pursuing the merger of P1679R0 and P1657R0 and forward it to LEWG for C++23, knowing that our time is scarce and this will leave less time for other work.

NO OBJECTION TO UNANIMOUS CONSENT.

Attendance: 18

End: 16:18

CONSENSUS: LEWGI sends the merger of P1679R0 and P1657R0, with the guidance below, to LEWG, for C++23.

@brycelelbach brycelelbach added C++23 Targeted at C++23 LEWG Library Evolution and removed LEWGI Library Evolution Incubator labels Jul 17, 2019
@tituswinters
Copy link

Discussing http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1679r0.html in

Forward to LWG for C++23 (but get the wording done).
SF F N A SA
1 10 5 1 1

Motion passes.

@tituswinters tituswinters added LWG Library and removed LEWG Library Evolution labels Jul 19, 2019
@jensmaurer jensmaurer modified the milestones: 2019-07, 2019-11 Aug 23, 2019
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 15, 2019

P1679R1 String Contains function (Wim Leflere, Paul Fee)

@JeffGarland JeffGarland added the lwg-prereview Needs LWG initial review before full group label Feb 17, 2020
@jensmaurer jensmaurer modified the milestones: 2019-11, 2020-06 Feb 18, 2020
@jensmaurer jensmaurer added IS Ship vehicle: IS and removed C++23 Targeted at C++23 labels Feb 18, 2020
@JeffGarland
Copy link
Member

Small group review notes for 3 minor updates on wiki. After revision should be ready for full group review.

@JeffGarland JeffGarland added lwg-fullreview Paper is ready for lwg full group review needs-revision Paper needs changes before it can proceed and removed lwg-prereview Needs LWG initial review before full group labels May 12, 2020
@wg21bot
Copy link
Collaborator Author

wg21bot commented May 21, 2020

P1679R2 String Contains function (Wim Leflere, Paul Fee)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label May 21, 2020
@JeffGarland
Copy link
Member

Reviewed by full LWG June 12th 2020. Final result:

Poll: Put this up for C++23?
No objection to unanimous consent.

ACTION: Wakely will review the updated changes so that LWG does not need to look at this again.

Review notes
https://wiki.edg.com/bin/view/Wg21summer2020/P1679R2StringContainsFunction

@wg21bot
Copy link
Collaborator Author

wg21bot commented Aug 1, 2020

P1679R3 String Contains function (Wim Leflere, Paul Fee)

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed lwg-fullreview Paper is ready for lwg full group review labels Sep 11, 2020
@ben-craig ben-craig added B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 size - small paper size estimate labels Oct 17, 2020
@jensmaurer jensmaurer mentioned this issue Nov 14, 2020
Merged
@JeffGarland JeffGarland added C++23 Targeted at C++23 and removed B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. LWG Library labels Mar 13, 2021
@cor3ntin cor3ntin added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Apr 22, 2021
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 26, 2021

Adopted 2020-11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - small paper size estimate
Projects
None yet
Milestone
2020-telecon
Development

Successfully merging a pull request may close this issue.

LWG Poll 4: P1679R3 string contains function cplusplus/draft
7 participants
@brycelelbach @ben-craig @cor3ntin @JeffGarland @tituswinters @jensmaurer @wg21bot