Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2370 Stacktrace from exception #1056

Open
wg21bot opened this issue Jun 26, 2021 · 16 comments
Open

P2370 Stacktrace from exception #1056

wg21bot opened this issue Jun 26, 2021 · 16 comments
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 C++26 Targeted at C++26 EWG Evolution IS Ship vehicle: IS needs-revision Paper needs changes before it can proceed size - medium paper size estimate

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Jun 26, 2021

P2370R0 Stacktrace from exception (Andrei Nekrashevich, Antony Polukhin)

@wg21bot wg21bot added LEWG Library Evolution LEWGI Library Evolution Incubator LWG Library labels Jun 26, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone Jun 26, 2021
@inbal2l inbal2l added ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jun 27, 2021
@brycelelbach brycelelbach added B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 size - medium paper size estimate IS Ship vehicle: IS and removed LEWGI Library Evolution Incubator LWG Library labels Aug 1, 2021
@wg21bot
Copy link
Collaborator Author

wg21bot commented Aug 23, 2021

P2370R1 Stacktrace from exception (Andrei Nekrashevich, Antony Polukhin)

@cor3ntin
Copy link

Mailing review 26-07-2021-13-09-2001

Lots of interest for this paper to land in 23 along the already approved stacktrace proposal.
A R1 was provided during the review addressing most of the concerns and feedback offered during the review.
A core expert offered some wording review

We probably still want to hear from implementers directly about the potential issues pertaining to ABI stability.

Given all the feedbacks were addressed and reviewers are happy with the general design and wording,
I recommend that this paper is reviewed during a LEWG telecon.

@cor3ntin cor3ntin added ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Sep 13, 2021
@brycelelbach brycelelbach added the C++23 Targeted at C++23 label Sep 17, 2021
@brycelelbach brycelelbach removed scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review C++23 Targeted at C++23 labels Nov 4, 2021
@brycelelbach
Copy link

Deferring to C++26 due to lack of time.

@eyalroz

This comment was marked as off-topic.

@NicolBolas

This comment was marked as off-topic.

@eyalroz

This comment was marked as off-topic.

@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@wg21bot
Copy link
Collaborator Author

wg21bot commented Jan 22, 2022

P2370R2 Stacktrace from exception (Andrei Nekrashevich, Antony Polukhin)

@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Jun 1, 2022
@brycelelbach
Copy link

2022-06-21 Library Evolution Telecon

P2370R2: Stacktrace from exception

2022-06-21 Library Evolution Telecon Minutes

P2490R0: Zero-overhead exception stacktraces

2022-06-21 Library Evolution Telecon Minutes

Chair: Bryce Adelstein Lelbach

Minute Taker: Ben Craig

Champion: Antony Polukhin (P2370) & Ed Catmur (P2490)

Start: 2022-06-21 11:51 Eastern

Does P2370 have:

  • Examples?
    • Yes
  • Field experience?
    • Yes. The field experience indicates that this can be done without
      an ABI break.
  • Performance considerations?
    • Yes. Performance overheads were a source of discussion with this proposal.
  • Discussion of prior art?
    • Yes.
  • Wording?
    • Yes.
  • Feature test macro?
    • Yes.

This needs to be seen by Evolution.

P2380R2 proposes capturing the stacktrace at the throw side and allows you to globally or per-thread enable/disable capturing stacktraces.

P2490R0 proposes to capture the stacktrace at entering the catch block rather than at the throw side.

End: 12:17

Summary

P2380R2 (Stacktrace from exceptions) and P2490R0 (Zero-overhead exception stacktraces) propose mechanisms for attaching stacktraces to exceptions.
P2380R2 proposes capturing the stacktrace at the throw side and allows you to globally or per-thread enable/disable capturing stacktraces.
P2490R0 proposes to capture the stacktrace at entering the catch block rather than at the throw side.

It became apparent during Library Evolution's review of these papers that they should be seen by Evolution first.
Once Evolution has decided upon a design direction for this feature, Library Evolution can review the Standard Library exposure of the feature.

Next Steps

Send P2380R2 (Stacktrace from exceptions) and P2490R0 (Zero-overhead exception stacktraces) to Evolution.

@brycelelbach brycelelbach removed the LEWG Library Evolution label Jun 21, 2022
@brycelelbach brycelelbach added EWG Evolution and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jun 21, 2022
@eyalroz

This comment was marked as off-topic.

@jwakely

This comment was marked as off-topic.

@erichkeane
Copy link
Collaborator

EWG saw this paper in the February 9th, 2023 morning session, and the following poll was taken:

Knowing our time is limited, EWG would like to see P2370R2 again, provided it includes language-level exploration/implementation experience.

SF F N A SA
1 12 12 4 0

Result: Not Consensus

@erichkeane erichkeane added the needs-revision Paper needs changes before it can proceed label Feb 9, 2023
@eyalroz

This comment was marked as off-topic.

@erichkeane

This comment was marked as off-topic.

@jensmaurer

This comment was marked as resolved.

@inbal2l

This comment was marked as resolved.

@cplusplus cplusplus deleted a comment from eyalroz Nov 26, 2023
@inbal2l

This comment was marked as resolved.

@jensmaurer jensmaurer removed this from the 2023-telecon milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 C++26 Targeted at C++26 EWG Evolution IS Ship vehicle: IS needs-revision Paper needs changes before it can proceed size - medium paper size estimate
Projects
None yet
Development

No branches or pull requests

9 participants