Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2499 string_view range constructor should be explicit #1158

Closed
wg21bot opened this issue Dec 18, 2021 · 7 comments · Fixed by cplusplus/draft#5688
Closed

P2499 string_view range constructor should be explicit #1158

wg21bot opened this issue Dec 18, 2021 · 7 comments · Fixed by cplusplus/draft#5688
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Milestone
2022-telecon

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Dec 18, 2021

P2499R0 string_view range constructor should be explicit (James Touton)
@wg21bot wg21bot added the LEWG Library Evolution label Dec 18, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone Dec 18, 2021
@inbal2l inbal2l added ranges std::ranges SG9 Ranges SG ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Dec 18, 2021
@brycelelbach brycelelbach added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 C++26 Targeted at C++26 IS Ship vehicle: IS size - tiny paper size estimate, smaller than small scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review and removed C++23 Targeted at C++23 labels Dec 22, 2021
@inbal2l inbal2l removed scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review SG9 Ranges SG labels Dec 22, 2021
@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@Bekenn
Copy link

Bekenn commented Jan 7, 2022

I neglected to specify a ship vehicle in the paper. It should be C++23. This is a fix for a feature that is new in C++23. If the fix is postponed, it will be a breaking change.

@jensmaurer
Copy link
Member

jensmaurer commented Jan 7, 2022 •
edited

@brycelelbach , please note that the author wants this as a C++23 fix (which we might very well apply as late as post-CD, since it's a fix for a new feature that could/should have also come in via an NB comment).

@inbal2l
Copy link
Collaborator

inbal2l commented Jan 7, 2022 •
edited

@Bekenn, @jensmaurer, thank you for getting our attention.
We figured it's a breaking change and originally scheduled this paper for a Jan LEWG ML review. @brycelelbach suggested we can see it post Feb as well (minor fix). In any case, I've updated the revision in the LEWG ML queue:
https://github.com/cplusplus/LEWG/wiki/2022-Mailing-List-Reviews

@vitaut
Copy link

vitaut commented Jan 7, 2022 •
edited

While the change itself is minor I wouldn't categorize P2499 as a minor fix because the new implicit conversions introduced in C++23 are extremely problematic. There will be one more paper about this in the January mailing but if P2499 was adopted sooner it would be even better.

@brycelelbach brycelelbach added C++23 Targeted at C++23 and removed C++26 Targeted at C++26 labels Jan 13, 2022
@brycelelbach brycelelbach added ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Feb 1, 2022
@cor3ntin cor3ntin mentioned this issue Mar 29, 2022
Closed
@cor3ntin
Copy link

cor3ntin commented Mar 29, 2022 •
edited by brycelelbach

2022-02-08 Library Evolution Telecon

P2499R0: string_view range constructor should be explicit

P2516R0: string_view is implicitly convertible from what?

2022-02-08 Library Evolution Telecon P2499 Minutes

2022-02-08 Library Evolution Telecon P2516 Minutes

POLL: We want to make the range constructor of string_view explicit (P2499R0)

Strongly Favor Favor Neutral Against Strongly Against
3 17 1 0 0

Attendance: 35

# of Authors: 1

Author Position: SF

Outcome: Consensus

A similar poll on P2516 (#1174) was taken, P2499 got stronger support, therefore was forwarded.

Next Steps

Take an electronic poll to send P2499R0 (string_view Range Constructor Should Be Explicit) to Library Working Group for C++23, classified as B2 - Improvement.

@cor3ntin cor3ntin added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting labels Mar 29, 2022
@brycelelbach brycelelbach removed the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Apr 1, 2022
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Apr 22, 2022
@brycelelbach brycelelbach added LWG Library lwg-pending LWG Chair needs to disposition and removed ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jun 19, 2022
@brycelelbach
Copy link

2022-05 Library Evolution Electronic Poll Outcomes

POLL: Send [P2499R0] string_view Range Constructor Should Be Explicit to Library Working Group for C++23, classified as an improvement of an existing feature ([P0592R4] bucket 2 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
13 7 1 2 0

Consensus in favor.

@brycelelbach brycelelbach removed the LEWG Library Evolution label Jun 19, 2022
@JeffGarland JeffGarland added lwg-fullreview Paper is ready for lwg full group review and removed lwg-pending LWG Chair needs to disposition labels Jul 4, 2022
@JeffGarland
Copy link
Member

LWG reviewed and approved 2022-07-08
Notes: https://wiki.edg.com/bin/view/Wg21telecons2022/P2499-20220708

poll: Put P2499r0 into C++23

F A N
16 0 1

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed lwg-fullreview Paper is ready for lwg full group review B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e size - tiny paper size estimate, smaller than small labels Jul 8, 2022
@cor3ntin cor3ntin added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Jul 25, 2022
@jensmaurer jensmaurer mentioned this issue Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Projects
None yet
Milestone
2022-telecon
Development

Successfully merging a pull request may close this issue.

P2499R0 string_view range constructor should be explicit cplusplus/draft
8 participants
@brycelelbach @vitaut @Bekenn @cor3ntin @JeffGarland @inbal2l @jensmaurer @wg21bot